Merge pull request #209 from popnikos/patch-1

Update AbstractApi autoescaping values

Author: kbsali

lib/Redmine/Api/AbstractApi.php

@@ -204,7 +204,7 @@ protected function attachCustomFieldXML(\SimpleXMLElement $xml, array $fields)
                     $_values->addChild('value', $val);
                 }
             } else {
-                $_field->addChild('value', $field['value']);
+                $_field->value = $field['value'];
             }
         }
 

tests/Unit/Api/IssueTest.php

@@ -687,6 +687,7 @@ public function testBuildXmlWithCustomFields()
             'custom_fields' => [
                 ['id' => 225, 'value' => 'One Custom Field'],
                 ['id' => 25, 'value' => 'Second Custom Field'],
+                ['id' => 321, 'value' => 'http://test.local/?one=first&two=second'],
             ],
         ];
 
@@ -704,7 +705,8 @@ public function testBuildXmlWithCustomFields()
                     $this->stringContains('<custom_fields type="array">'),
                     $this->stringContains('</custom_fields>'),
                     $this->stringContains('<custom_field id="225"><value>One Custom Field</value></custom_field>'),
-                    $this->stringContains('<custom_field id="25"><value>Second Custom Field</value></custom_field>')
+                    $this->stringContains('<custom_field id="25"><value>Second Custom Field</value></custom_field>'),
+                    $this->stringContains('<custom_field id="321"><value>http://test.local/?one=first&amp;two=second</value></custom_field>')
                 )
             );