Add new NativeCurlClient #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md Replace Redmine\Client with NativeCurlClient in docs Fix some spelling errors
Collaborator
Author
|
Hey @kbsali this PR is ready for review. I've implemented nearly all existing features from the old client in the new I've also created a migration doc and changed the README to not mention the old client anymore. |
Co-authored-by: Kevin Saliou <kevin@saliou.name>
kbsali
approved these changes
Apr 11, 2021
Owner
kbsali
left a comment
kbsali
left a comment
There was a problem hiding this comment.
thanks for taking the time to apply some of my comments! :) 👍
Collaborator
Author
|
Can I resolve all open conversations and merge this PR? |
Owner
|
please do yes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR is a new NativeCurlClient like the existing one, that will work native with curl without other dependencies. I'm still at the work figuring out the necessary public method that will be needed. In the next major release this client should replace the existing
Redmine\Client.In the best case every curl options could be managed with
setCurlOption()andunsetCurlOption(), but now I have to create a way to manage the possible setted headers.