Skip to content

Conversation

@kbsali
Copy link
Owner

@kbsali kbsali commented Sep 20, 2023

No description provided.

@kbsali kbsali marked this pull request as ready for review September 20, 2023 11:53
@kbsali kbsali requested a review from Art4 September 20, 2023 11:53
Copy link
Collaborator

@Art4 Art4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. 😊

@kbsali kbsali force-pushed the chore/add-artur-to-authors branch from 30e53ce to fc43c53 Compare September 20, 2023 13:13
@kbsali
Copy link
Owner Author

kbsali commented Sep 20, 2023

@Art4 I have tried to setup codecov but it fails at generating the coverage file... not sure how to fix this 🙏

Copy link
Collaborator

@Art4 Art4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made two suggestions to setup Codecov properly.

Co-authored-by: Artur Weigandt <Art4@users.noreply.github.com>
@kbsali kbsali force-pushed the chore/add-artur-to-authors branch from cfd98d0 to f7cc401 Compare September 21, 2023 09:20
Co-authored-by: Artur Weigandt <Art4@users.noreply.github.com>
@kbsali kbsali force-pushed the chore/add-artur-to-authors branch from f7cc401 to 8e05ba1 Compare September 21, 2023 09:22
@codecov
Copy link

codecov bot commented Sep 21, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@kbsali kbsali merged commit 0c05477 into v2.x Sep 21, 2023
@kbsali
Copy link
Owner Author

kbsali commented Sep 21, 2023

👍

@Art4 Art4 deleted the chore/add-artur-to-authors branch December 28, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants