Implement support for references in permission claims #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old code would loop through all bound claims and for each matching (group/resource) claim it would try to find the first (!) matching exported claim. And then check the verbs. If no exported claim is found, the set of allowed verbs is empty, so the HasAny() check can never succeed. Hence if no exported claim exists, we do not even have to check the verbs. This commit improves the loop by comparing all bound claims against all (!) exported claims (with the matching GRI) and skipping any guaranteed-false checks if no exported claim is found. This loop now is ready to be extended to check for references, too. On-behalf-of: @SAP christoph.mewes@sap.com
kcp-ci-bot
added
kind/feature
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
size/M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #3409
Release Notes