Add GitHub Action for building and pushing images #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP marko.mudrinic@sap.com Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kcp-ci-bot
added
dco-signoff: yes
|
LGTM label has been added. Git tree hash: 186fde87580c173c795b796e8d26a2ad503427c2
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action for building and pushing images. The image is built using
docker buildxand pushed to GHCR asghcr.io/kcp-dev/publishing-bot. The image is built for AMD64 and ARM64 platforms. Tags in use are:latest- when pushing tomasterWe're pushing the
latesttag because it makes configuring and runningpublishing-boteasier. If we were using only SHA or tag, we would have to change the publishing-bot configuration in a separate PR after each successful push; I don't think we really need that here, we can just use latest.The action is ran on pull requests for changes to this action and Dockerfile, on each push to
master, and on semver tags. Push is done only for pushes tomasterand on semver tags.Note: I'll create a follow up PR to update Makefile to use
docker buildx/assign @xrstf