Refactor TrayApp visibility and dialog positioning logic #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
kdroidFilter
commented
Sep 30, 2025
kdroidFilter
commented
- Removed `TrayAppState` dependency in favor of simplified visibility toggling with persistent composable state. - Added `visibleOnStart` parameter for better control of initial window visibility. - Improved handling of focus loss and outside-click behavior for smoother user experience. - Enhanced documentation for overloads and core implementation.
… and enhance visibility and size management - Added `TrayAppState` integration for centralized state management. - Deprecated `windowSize` and `visibleOnStart` in favor of `TrayAppState` properties. - Improved logic for visibility handling and window positioning. - Refined dialog size updates and state synchronization.
- Added macOS-specific delay to resolve concurrency issue when positioning the dialog. - Improved focus loss behavior with a startup grace period on Windows. - Enabled front positioning for dialog window upon opening. - Added fade animation for content wrapper.
- Added multi-step initialization process for macOS and Windows to stabilize icon position and dialog placement. - Refined dialog state updates to ensure accurate positioning before visibility toggle. - Enhanced inline comments for better code clarity.
- Consolidated visibility handling into a single LaunchedEffect. - Added polling loop to ensure valid window position before showing. - Removed redundant initialization code and streamlined state updates.
…g positioning reliability
- Unified position calculation and visibility logic before showing tray window. - Adjusted delays for better cross-platform consistency. - Improved code readability by restructuring `try-catch` blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.