-
Notifications
You must be signed in to change notification settings - Fork 251
ui: dark mode for installation components fixed #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kaushik Tak <kaushiktak19@gmail.com>
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 can you please make the same change in the EnterpriseInstallReminder?? it is newly created you can use this same styling in that component
Signed-off-by: Kaushik Tak <kaushiktak19@gmail.com>
|
Okay @Achanandhi-M , have made those changes - |
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kaushiktak19 I have reviewed your PR, changes are really good but can you please make the text properly aligned currently, the text inside the box is not good
Sure @Achanandhi-M , by align are u addressing the the extra space above first line, top margin ? or its soemthing else, if u could clarify. |
yes, the content is not properly aligned there is no equal spaces |
Signed-off-by: Kaushik Tak <kaushiktak19@gmail.com>
|
@Achanandhi-M , Is this fine ? |
Good one @kaushiktak19 |
amaan-bhati
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Achanandhi-M
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM






What has changed?
Implemented proper dark mode styling for src/components/InstallReminder.js and src/components/EnterpriseInstallReminder.js (dark background, border, shadow and text colors).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran npm run build and npm run serve to check if the changes are working as expected.
Build Check :

Changes :
Checklist: