-
Notifications
You must be signed in to change notification settings - Fork 307
Skip exporting BART, T5 and Whisper for 0.5 release #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/gcbrun |
|
A few notes here...
Re 2., that might mean we have a little more release work to do on the 0.5 branch if we want to bring in a lot of new commits from the master branch. E.g. git checkout r0.5
# Fetch all new commits on master exactly.
git reset --hard upstream/master
# Re cherry pick this commit.
git cherry-pick {HASH_OF_THIS_PR}
# Force push.
git push -f upstream r0.5We should probably avoid a force push like that after a release, but could do something like that for now. |
keras_nlp/__init__.py
Outdated
| from keras_nlp import utils | ||
|
|
||
| __version__ = "0.5.0" | ||
| __version__ = "0.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should always keep the patch release number.
The branch is r0.5 as it will be continued to update patch release to patch release. (See core keras for example).
But the version numbers we expose from the library should always follow https://semver.org/, with three parts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we are cutting more dev releases from here, should we keep a devX postfix for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg!
* Version bump to 0.5.0.dev0 (#1002) * Skip exporting BART, T5 and Whisper * remove export * fix version number * fix version number
* Version bump to 0.5.0.dev0 (#1002) * Skip exporting BART, T5 and Whisper * remove export * fix version number * fix version number
* Version bump to 0.5.0.dev0 (#1002) * Skip exporting BART, T5 and Whisper * remove export * fix version number * fix version number
We are pre-release, and we need to avoid exporting these for 0.5.