Skip to content

Conversation

@chenmoneygithub
Copy link
Contributor

We are pre-release, and we need to avoid exporting these for 0.5.

@chenmoneygithub
Copy link
Contributor Author

/gcbrun

@mattdangerw
Copy link
Member

A few notes here...

  1. We should also switch the keras_nlp_export calls on these symbols to keras.utils.register_keras_serializable, as that will be used to generate the eventual pip package.
  2. We might want to target the release branch for this change, so that work can continue unobstructed on the main branch for things like the BartSeq2SeqLM.

Re 2., that might mean we have a little more release work to do on the 0.5 branch if we want to bring in a lot of new commits from the master branch. E.g.

git checkout r0.5
# Fetch all new commits on master exactly.
git reset --hard upstream/master
# Re cherry pick this commit.
git cherry-pick {HASH_OF_THIS_PR}
# Force push.
git push -f upstream r0.5

We should probably avoid a force push like that after a release, but could do something like that for now.

@chenmoneygithub chenmoneygithub changed the base branch from master to r0.5 April 27, 2023 00:51
from keras_nlp import utils

__version__ = "0.5.0"
__version__ = "0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should always keep the patch release number.

The branch is r0.5 as it will be continued to update patch release to patch release. (See core keras for example).

But the version numbers we expose from the library should always follow https://semver.org/, with three parts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we are cutting more dev releases from here, should we keep a devX postfix for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg!

@chenmoneygithub chenmoneygithub merged commit ab096cb into keras-team:r0.5 Apr 27, 2023
chenmoneygithub added a commit that referenced this pull request May 5, 2023
* Version bump to 0.5.0.dev0 (#1002)

* Skip exporting BART, T5 and Whisper

* remove export

* fix version number

* fix version number
chenmoneygithub added a commit that referenced this pull request May 5, 2023
* Version bump to 0.5.0.dev0 (#1002)

* Skip exporting BART, T5 and Whisper

* remove export

* fix version number

* fix version number
chenmoneygithub added a commit that referenced this pull request May 11, 2023
* Version bump to 0.5.0.dev0 (#1002)

* Skip exporting BART, T5 and Whisper

* remove export

* fix version number

* fix version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants