Ditch Keras 2 support #1658
Merged
Ditch Keras 2 support #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
force-pushed
the
ditch-keras-2
branch
from
edb8c29 to
a3b9cdb
Compare
|
Does this also get rid of the dependency on |
mattdangerw
force-pushed
the
ditch-keras-2
branch
from
a3b9cdb to
88e8a56
Compare
|
@tirthasheshpatel yes, let me add that! |
mattdangerw
force-pushed
the
ditch-keras-2
branch
4 times, most recently
from
acfc68f to
77c20fd
Compare
mattdangerw
force-pushed
the
ditch-keras-2
branch
2 times, most recently
from
e05bdb0 to
f6b4de3
Compare
|
Going to rebase this and try it out (will just be nightly and github from HEAD for a bit). Please open an issue if this breaks you! |
mattdangerw
force-pushed
the
ditch-keras-2
branch
from
f6b4de3 to
d22c83a
Compare
divyashreepathihalli
approved these changes
Jun 18, 2024
|
I'm curious about what the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft to asses implications. At some point, KerasNLP will drop support for Keras 2, so we can focus on newer features in the library (multi-backend, model parallel training, quantization, etc).
Feel free to drop a comment if this would affect your workflow!