Fix saved classifier models from before 0.14 #1839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switched the class name for `XXClassifier` models to `XXTextClasssifier`. However, a saved classifier before 0.16 will still be looking for the class under the old name. This updates our export helper to also registered the old name, so we can restore to the new class when loading the model. I also try to improve our error messages when we do encounter an unrecognized class.
mattdangerw
added a commit
that referenced
this pull request
Sep 18, 2024
We switched the class name for `XXClassifier` models to `XXTextClasssifier`. However, a saved classifier before 0.16 will still be looking for the class under the old name. This updates our export helper to also registered the old name, so we can restore to the new class when loading the model. I also try to improve our error messages when we do encounter an unrecognized class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1795 (comment)
We switched the class name for
XXClassifiermodels toXXTextClasssifier. However, a saved classifier before 0.16 will still be looking for the class under the old name.This updates our export helper to also registere the old name, so we can restore to the new class when loading the model.
I also try to improve our error messages when we do encounter an unrecognized class.