Update README #1890
Merged
Update README #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
reviewed
Sep 29, 2024
README.md
Outdated
| [keras.io/keras_nlp](https://keras.io/keras_nlp/). | ||
|
|
||
| ## Installation | ||
| KerasHub that is currently available on PiPy is a pre release version. |
Member
There was a problem hiding this comment.
Newline after markdown heading. Don't recommend pinning the version. Also I would do a little more than this probably?
- Very briefly explain what the pre-release means, e.g. new api might change a lot before release.
- Recommend
pip install keras-nlpfor a stable experience. - Don't show
pip install keras-hubat all now. Recommendpip install keras-hub-nightlyfor people that want to try the pre-release of keras-hub. - Update the quickstart to show
import keras_nlpandkeras_nlpusages. - Finally make a new PR with the release day updates you want and leave it staged (but not merged). We land it at the same time we land keras.io updates. This readme is docs, like keras.io.
VarunS1997
approved these changes
Sep 30, 2024
| ) | ||
|
|
||
| # Load a BERT model. | ||
| classifier = keras_hub.models.Classifier.from_preset( |
Collaborator
There was a problem hiding this comment.
Did we mean to change this back to keras_nlp?
Looks like yes, but wanted to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.