Add "Getting Started" guide for KerasNLP #1159
Conversation
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Just leaving some random rendering comments I noticed when generating this.
jbischof
changed the title
mattdangerw
left a comment
mattdangerw
left a comment
There was a problem hiding this comment.
Just did a pass on some of the hyperlinks!
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
The images appear to be pixellated (the text below them especially). Can you generate clean ones? Also, no need to add them to the git tree (in general it should be avoided since it increases the size of the repo, which we're constantly downloading), you can put them on imgur.
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Looking good! Please add the generated files.
Please note that I've pushed minor copyedits (in particular, using absolute URLs for links, which is necessary since many folks use the tutorial interactively via the Colab link where relative URLs wouldn't work). Pull them first.
Oops, my bad! I asked for this. Thought relative would be better for previews, but the colab issue makes sense. |
|
What a well-written guide! Love it. |
4 participants
No description provided.