Fixing various errors in the structured_data files #2013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Jan 2, 2025
Contributor
fchollet
left a comment
fchollet
left a comment
There was a problem hiding this comment.
Thanks for the PR! Can you please also fix the issues in the corresponding .md and .ipynb files?
Contributor
Author
|
Find the generated |
fchollet
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various similar errors related to data download and Dataset preparation in various scripts in the
structured_dataexamples. It includes:movielens_recommendations_transformers.py,wide_deep_cross_networks.py, andfeature_space_advanced.py.Detailed errors description may also be referenced from PR.
More information about the error from the function tree_flatten doc string.
OrderedDictwhen flattened keeps its keys insertion order, anddictdoes not. In our modelsinputsare a dict anddatasetis an OrderedDict.A fix has been provided.