Skip to content

Conversation

@ariG23498
Copy link
Contributor

This is a minimal implementation of ShiftViT. In this paper the authors have proposed to replace the attention module of a ViT with a NO PARAMETER shifting operation. In this example we have tried aligning the implementation as closely as we could with the official implementation in PyTorch. We hope this will benefit the keras community.

Colab Notebook

CC: @ritwikraha

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 👍

Please format the code using black.

@ariG23498
Copy link
Contributor Author

Thank you for the review @fchollet

We have made the necessary changes!

@ariG23498 ariG23498 requested a review from fchollet February 26, 2022 04:19
Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! I pushed some copyedits.

@ariG23498
Copy link
Contributor Author

@fchollet I have made changes as requested!

@ariG23498 ariG23498 requested a review from fchollet February 28, 2022 19:43
@ariG23498
Copy link
Contributor Author

ariG23498 commented Mar 1, 2022

Thanks for the thorough review @fchollet

We have added the generated files after some minor edits (removing spaces and adding a period to the description).

Note: The code was more than 300 lines, so we modified the tutobook.py and generated the files. Will that be a problem?

Copy link
Contributor

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you for the great contribution! 👍

@fchollet
Copy link
Contributor

fchollet commented Mar 1, 2022

Note: The code was more than 300 lines, so we modified the tutobook.py and generated the files. Will that be a problem?

As much as possible, this should be avoided, but it's not a blocker.

@fchollet fchollet merged commit b2692ef into keras-team:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants