Skip to content

Conversation

hertschuh
Copy link
Collaborator

…s a single input argument.

Fixes tensorflow/tensorflow#69307

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.07%. Comparing base (f81009b) to head (9f49f6b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19948   +/-   ##
=======================================
  Coverage   79.07%   79.07%           
=======================================
  Files         499      499           
  Lines       46730    46726    -4     
  Branches     8618     8617    -1     
=======================================
  Hits        36950    36950           
+ Misses       8045     8043    -2     
+ Partials     1735     1733    -2     
Flag Coverage Δ
keras 78.93% <100.00%> (+<0.01%) ⬆️
keras-jax 62.26% <0.00%> (+<0.01%) ⬆️
keras-numpy 57.29% <0.00%> (+<0.01%) ⬆️
keras-tensorflow 63.56% <100.00%> (+<0.01%) ⬆️
keras-torch 62.32% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hertschuh hertschuh requested a review from nkovela1 July 2, 2024 23:06
@hertschuh hertschuh requested a review from fchollet July 2, 2024 23:06
Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 3, 2024
@fchollet fchollet merged commit d910dcb into keras-team:master Jul 3, 2024
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jul 3, 2024
@hertschuh hertschuh deleted the save_model_multi branch July 3, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The signatures in SavedModel do not contain serving_default when a subclass of the keras model has multiple inputs

4 participants