Skip to content

Conversation

@james77777778
Copy link
Contributor

I need left_shift and right_shift in some cases.
After implementing them, I realized that it might be useful to add these bitwise ops.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 82.26950% with 50 lines in your changes missing coverage. Please review.

Project coverage is 79.33%. Comparing base (b45be33) to head (739d608).
Report is 24 commits behind head on master.

Files Patch % Lines
keras/src/ops/numpy.py 82.60% 20 Missing ⚠️
keras/api/_tf_keras/keras/ops/__init__.py 0.00% 9 Missing ⚠️
keras/api/_tf_keras/keras/ops/numpy/__init__.py 0.00% 9 Missing ⚠️
keras/src/backend/jax/numpy.py 89.65% 3 Missing ⚠️
keras/src/backend/numpy/numpy.py 89.65% 3 Missing ⚠️
keras/src/backend/tensorflow/numpy.py 93.18% 3 Missing ⚠️
keras/src/backend/torch/numpy.py 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20126      +/-   ##
==========================================
+ Coverage   79.29%   79.33%   +0.03%     
==========================================
  Files         501      501              
  Lines       46984    47270     +286     
  Branches     8659     8672      +13     
==========================================
+ Hits        37258    37503     +245     
- Misses       7976     8019      +43     
+ Partials     1750     1748       -2     
Flag Coverage Δ
keras 79.19% <82.26%> (+0.03%) ⬆️
keras-jax 62.45% <55.67%> (-0.04%) ⬇️
keras-numpy 57.55% <58.86%> (+0.05%) ⬆️
keras-tensorflow 63.83% <60.99%> (+<0.01%) ⬆️
keras-torch 62.49% <55.67%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, that's definitely useful. Thank you for the contribution -- LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Aug 15, 2024
@fchollet fchollet merged commit d72a0ea into keras-team:master Aug 15, 2024
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Aug 15, 2024
@james77777778 james77777778 deleted the add-bitwise-ops branch August 16, 2024 01:25
ryantqiu pushed a commit to snorkel-marlin-repos/keras-team_keras_pr_20126_1b189dbc-9346-4e07-9e8a-14466338ab1a that referenced this pull request Oct 1, 2025
Original PR #20126 by james77777778
Original: keras-team/keras#20126
ryantqiu added a commit to snorkel-marlin-repos/keras-team_keras_pr_20126_1b189dbc-9346-4e07-9e8a-14466338ab1a that referenced this pull request Oct 1, 2025
Merged from original PR #20126
Original: keras-team/keras#20126
ryantqiu pushed a commit to snorkel-marlin-repos/keras-team_keras_pr_20126_49447ad3-98a1-46d9-89c5-77bbba3d420f that referenced this pull request Oct 2, 2025
Original PR #20126 by james77777778
Original: keras-team/keras#20126
ryantqiu added a commit to snorkel-marlin-repos/keras-team_keras_pr_20126_49447ad3-98a1-46d9-89c5-77bbba3d420f that referenced this pull request Oct 2, 2025
Merged from original PR #20126
Original: keras-team/keras#20126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants