-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Update Torch to 2.9.0 on GPU. #21756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @hertschuh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the PyTorch dependency across various configuration files to version 2.9.0. The primary objective is to bring the project's GPU-accelerated environments up to the latest stable Torch release, while also ensuring that the corresponding CPU-only testing configurations are aligned. This update aims to incorporate the newest features, performance improvements, and bug fixes available in PyTorch 2.9.0. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Torch version to 2.9.0 across different requirement files. The updates for CPU-only Torch installations in requirements-jax-cuda.txt and requirements-tensorflow-cuda.txt appear correct. However, I have a significant concern regarding the update in requirements-torch-cuda.txt. I've left a comment detailing a likely version incompatibility between torch==2.9.0 and torch-xla==2.8.1, which could break the build for the Torch+XLA on CUDA environment. This should be addressed before merging.
| torch==2.9.0 | ||
| torch-xla==2.8.1;sys_platform != 'darwin' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change introduces a potential version incompatibility. torch-xla versions are tightly coupled with torch versions, and torch-xla==2.8.1 is designed for torch==2.8.x. Using it with torch==2.9.0 is likely to cause build or runtime errors.
The comment on line 6 (# - torch is pinned to a version that is compatible with torch-xla.) reinforces this concern.
Since a torch-xla version compatible with torch==2.9.0 does not appear to be publicly available yet, this torch version bump might be premature for the CUDA environment with XLA. It would be best to either update torch-xla to a compatible version if one is available, or revert the torch update in this file until a compatible torch-xla is released.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21756 +/- ##
=======================================
Coverage 82.63% 82.63%
=======================================
Files 572 572
Lines 58555 58555
Branches 9153 9153
=======================================
Hits 48385 48385
Misses 7843 7843
Partials 2327 2327
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Replaces #21744