Fix failing sklearn tests following release of pytest 9.0.

[hertschuh]

A regression in pytest 9.0 causes unittest.SkipTest exceptions to not be handled anymore.

[gemini-code-assist]

Summary of Changes

Hello @hertschuh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where sklearn tests were failing due to a regression introduced in pytest version 9.0. Specifically, pytest stopped correctly handling unittest.SkipTest exceptions, leading to test failures instead of skips. The changes implement a workaround to ensure these exceptions are properly caught and translated into pytest.skip calls, restoring the expected behavior of the test suite.

Highlights

• Pytest 9.0 Regression Fix: Addresses a regression introduced in pytest 9.0 where unittest.SkipTest exceptions were no longer handled, causing sklearn tests to fail instead of being skipped.
• Explicit Test Skipping: Introduces an explicit check for unittest.SkipTest exceptions within the test suite's exception handling, converting them into pytest.skip calls to correctly mark tests as skipped.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fix for failing scikit-learn compatibility tests, which is caused by a regression in pytest version 9.0 where unittest.SkipTest exceptions are no longer handled automatically. The change correctly catches unittest.SkipTest and calls pytest.skip(), ensuring these tests are skipped as intended rather than failing. The implementation is correct and includes a helpful comment linking to the upstream issue. The changes look good.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.66%. Comparing base (19ca9c1) to head (23aa189).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21843   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         577      577           
  Lines       59477    59477           
  Branches     9329     9329           
=======================================
  Hits        49167    49167           
  Misses       7907     7907           
  Partials     2403     2403           

Flag	Coverage Δ
keras	82.48% <ø> (ø)
keras-jax	63.31% <ø> (ø)
keras-numpy	57.54% <ø> (ø)
keras-openvino	34.34% <ø> (ø)
keras-tensorflow	64.12% <ø> (ø)
keras-torch	63.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.