Fix typo in muon_test.py

[Abhinavexists]

typo fix in the muon_test.py -> variable name 'embeding' to 'embedding'

[gemini-code-assist]

Summary of Changes

Hello @Abhinavexists, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important code quality improvement by fixing a typo in a test file. The change ensures consistency and accuracy in variable naming, enhancing the readability and maintainability of the codebase.

Highlights

• Typo Correction: Corrected the misspelling of the variable embeding to embedding within the muon_test.py file.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request corrects a typo in the muon_test.py file by renaming the variable embeding to embedding. The change is correct and improves code readability. I have also added a suggestion to use a more idiomatic assertion method for boolean checks, which improves the test's clarity.

[gemini-code-assist]

assertAllClose is generally used for comparing floating-point arrays. For a boolean check like this, using self.assertEqual is more idiomatic and clearly conveys the intent of the assertion without unnecessary type conversions.

Suggested change

	self.assertAllClose(
	True,
	optimizer._should_use_adamw(embeding.weights[0]),
	optimizer._should_use_adamw(embedding.weights[0]),
	)
	self.assertEqual(
	True,
	optimizer._should_use_adamw(embedding.weights[0]),
	)

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.66%. Comparing base (bfde12b) to head (a2cc0a8).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #21845   +/-   ##
=======================================
  Coverage   82.66%   82.66%           
=======================================
  Files         577      577           
  Lines       59506    59506           
  Branches     9330     9330           
=======================================
  Hits        49193    49193           
  Misses       7910     7910           
  Partials     2403     2403           

Flag	Coverage Δ
keras	82.49% <ø> (ø)
keras-jax	63.31% <ø> (ø)
keras-numpy	57.55% <ø> (+<0.01%)	⬆️
keras-openvino	34.35% <ø> (ø)
keras-tensorflow	64.12% <ø> (ø)
keras-torch	63.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.