Skip to content

Commit cf6bcc2

Browse files
committed
Move app token generation to just before release steps
GitHub App installation tokens expire after 1 hour. Previously the token was generated at the very start of the workflow, before three full kernel builds. On a 2-core runner these builds can easily exceed 1 hour, causing the token to expire before the release creation and asset upload steps. Move the token generation step to immediately before the 'Create release' step so the token is fresh when it is actually needed.
1 parent d8d1b0a commit cf6bcc2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/release.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,6 @@ jobs:
77
name: Release
88
runs-on: ubuntu-22.04
99
steps:
10-
- name: Generate app token
11-
id: app-token
12-
uses: actions/create-github-app-token@v1
13-
with:
14-
app-id: ${{ secrets.ADMIN_APP_ID }}
15-
private-key: ${{ secrets.ADMIN_APP_PRIVATE_KEY }}
1610
- name: Code checkout
1711
uses: actions/checkout@v4
1812
with:
@@ -31,6 +25,12 @@ jobs:
3125
run: make ch_defconfig
3226
- name: Build kernel (x86-64)
3327
run: CFLAGS="-Wa,-mx86-used-note=no" make bzImage -j `nproc`
28+
- name: Generate app token
29+
id: app-token
30+
uses: actions/create-github-app-token@v1
31+
with:
32+
app-id: ${{ secrets.ADMIN_APP_ID }}
33+
private-key: ${{ secrets.ADMIN_APP_PRIVATE_KEY }}
3434
- name: Create release
3535
id: create_release
3636
uses: actions/create-release@v1

0 commit comments

Comments
 (0)