test: add units tests for hardware details helpers #1544
Merged
+1,738
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gustavobtflores
force-pushed
the
unit-tests-hardware-helpers
branch
4 times, most recently
from
4e69acb to
43f51e5
Compare
backend/kernelCI_app/tests/unitTests/helpers/fixtures/hardware_details_data.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/fixtures/hardware_details_data.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/helpers/hardwareDetails_helpers_test.py
Outdated
Show resolved
Hide resolved
gustavobtflores
force-pushed
the
unit-tests-hardware-helpers
branch
from
5b51622 to
d012b11
Compare
MarceloRobert
approved these changes
Oct 31, 2025
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
Tests look good, there are just some unnecessary comments there, otherwise it's ok. I'll pre-approve
gustavobtflores
force-pushed
the
unit-tests-hardware-helpers
branch
2 times, most recently
from
73f89c1 to
ff027d3
Compare
- Add missing edge cases for hardware details validation - Improve assertion specificity in test cases - Remove unused variables from hardware details fixtures - Refactor test organization by moving tests between classes
gustavobtflores
force-pushed
the
unit-tests-hardware-helpers
branch
from
ff027d3 to
51a7187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase to 50%