test: add unit tests for process_submissions helpers #1607
Merged
+576
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-faria-dev
force-pushed
the
1611-add-process-submissions-tests
branch
3 times, most recently
from
c012639 to
826632b
Compare
MarceloRobert
added
CI/CD
Contributor
gustavobtflores
left a comment
gustavobtflores
left a comment
There was a problem hiding this comment.
Looks great overall, just some minor comments
Comment on lines
448
to
474
| @patch("kernelCI_app.management.commands.helpers.process_submissions.logger") | ||
| @patch( | ||
| "kernelCI_app.management.commands.helpers.process_submissions.make_issue_instance" | ||
| ) | ||
| def test_insert_items_with_errors(self, mock_make_issue, mock_logger): | ||
| items = [{"id": "issue", "version": 1, "origin": "test"}] | ||
|
|
||
| mock_make_issue.side_effect = ValidationError.from_exception_data( | ||
| "TestModel", [] | ||
| ) | ||
| result = insert_items("issues", items) | ||
| self.assertEqual(result, 0) | ||
| self.assertEqual(mock_logger.error.call_count, 1) | ||
|
|
||
| mock_make_issue.reset_mock() | ||
| mock_logger.reset_mock() | ||
|
|
||
| mock_issue = MagicMock() | ||
| mock_issue.save = MagicMock(side_effect=IntegrityError("Duplicate key")) | ||
| mock_make_issue.return_value = mock_issue | ||
| result = insert_items("issues", items) | ||
| self.assertEqual(result, 0) | ||
| self.assertEqual(mock_logger.error.call_count, 1) |
Contributor
There was a problem hiding this comment.
could we separate this test in two different cases?
1 - ValidationError
2 - IntegrityError
Comment on lines
+426
to
+430
| class TestInsertItems(SimpleTestCase): | ||
| @patch("kernelCI_app.management.commands.helpers.process_submissions.logger") | ||
| @patch( | ||
| "kernelCI_app.management.commands.helpers.process_submissions.make_issue_instance" | ||
| ) |
Contributor
There was a problem hiding this comment.
we could add a test case with an empty items list in this class, just in case
Contributor
Author
There was a problem hiding this comment.
Thanks, applied both comments. Can you check pls?
joao-faria-dev
force-pushed
the
1611-add-process-submissions-tests
branch
from
826632b to
9028eea
Compare
gustavobtflores
approved these changes
Nov 12, 2025
Contributor
gustavobtflores
left a comment
gustavobtflores
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
Could you please just rebase the branch with main? I will merge it then
joao-faria-dev
force-pushed
the
1611-add-process-submissions-tests
branch
from
9028eea to
b2cc252
Compare
Contributor
Author
|
Just rebased @gustavobtflores |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Description
Add test coverage for the helpers functions on
process_submissions.py