test(queries): add unit tests for query modules #1609
Merged
+1,274
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joao-faria-dev
force-pushed
the
1498-add-tests-for-queries
branch
from
cf57e99 to
18ca23c
Compare
joao-faria-dev
changed the title
Contributor
Author
|
ready for review guys @MarceloRobert @gustavobtflores |
MarceloRobert
requested changes
Nov 14, 2025
backend/kernelCI_app/tests/unitTests/queries/hardware_queries_test.py
Outdated
Show resolved
Hide resolved
backend/kernelCI_app/tests/unitTests/queries/notifications_test.py
Outdated
Show resolved
Hide resolved
joao-faria-dev
force-pushed
the
1498-add-tests-for-queries
branch
2 times, most recently
from
617ec69 to
e6a2391
Compare
Collaborator
|
@joao-faria-dev there's still some pending comments for the issue queries tests |
joao-faria-dev
force-pushed
the
1498-add-tests-for-queries
branch
5 times, most recently
from
db5be38 to
f5661d0
Compare
MarceloRobert
added
the
CI/CD
MarceloRobert
approved these changes
Nov 17, 2025
Collaborator
MarceloRobert
left a comment
MarceloRobert
left a comment
There was a problem hiding this comment.
Still some unused vars, they could be used in some assert like assert_called_once() just to not let them go unused. But considering the overall PR, this is minimal so I'll approve
joao-faria-dev
force-pushed
the
1498-add-tests-for-queries
branch
2 times, most recently
from
3075dd5 to
36f9063
Compare
- Add tests for build, checkout, issues and test query modules Part of kernelci#1498
- Add tests for hardware, notifications and tree modules Closes kernelci#1498
joao-faria-dev
force-pushed
the
1498-add-tests-for-queries
branch
from
36f9063 to
4ccf333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for all the queries modules
Progress
Related issue
Part of #1498