Improve watch command output #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can push some of messages we print today out for clear view for our audience who only want to see info relevant to their test and tree. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Abort won't exit immedially, but generate an Click execption instead. However, we want to exit right away. The suggestion is to just use sys.exit() Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Our users don't need to see the background infomation from Maestro. We can show only the needful information. With time we will also show links to logs and other info in concise way. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
padovan
force-pushed
the
improve-watch
branch
from
43dfc05 to
4d87114
Compare
aliceinwire
reviewed
Feb 5, 2025
| except requests.exceptions.HTTPError as ex: | ||
| kci_err(ex.response.json().get("detail")) | ||
| click.Abort() | ||
| sys.exit(errno.ENOENT) |
Member
There was a problem hiding this comment.
why use errno.ENOENT? I thought was referred only to local directory not for HTTPError
ENOENT means "No such file or directory", and is for path operations.
aliceinwire
reviewed
Feb 5, 2025
| required=False, | ||
| ) | ||
| @click.option("--instance", help="API instance to use", required=False) | ||
| @click.option("--debug", is_flag=True, help="Enable debug info") |
Member
|
please remove the debug related commits from this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show only relevant information. Next step we will add an option to download the logs.