Skip to content

results: add --arch filter #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

results: add --arch filter #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f322f0c
results: add --arch filter
CamilaAlvarez Mar 4, 2025
edcecad
Add documentation for arch filter
CamilaAlvarez Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions docs/results.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,15 @@ Example:
kci-dev results boots --giturl 'https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git' --branch master --latest --filter=filter.yaml
```

## --arch

Filters results by arch.

Example:
```sh
kci-dev results summary --giturl 'https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git' --branch master --latest --arch arm64
```

### without arguments

If used without arguments, `kci-dev results` subcommands will get KernelCI status
Expand Down
42 changes: 21 additions & 21 deletions kcidev/subcommands/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,47 +55,51 @@ def dashboard_api_fetch(endpoint, params, max_retries=3):
raise click.Abort()


def dashboard_fetch_summary(origin, giturl, branch, commit):
def dashboard_fetch_summary(origin, giturl, branch, commit, arch):
endpoint = f"tree/{commit}/summary"
params = {
"origin": origin,
"git_url": giturl,
"git_branch": branch,
}

if arch is not None:
params["filter_architecture"] = arch
return dashboard_api_fetch(endpoint, params)


def dashboard_fetch_builds(origin, giturl, branch, commit):
def dashboard_fetch_builds(origin, giturl, branch, commit, arch):
endpoint = f"tree/{commit}/builds"
params = {
"origin": origin,
"git_url": giturl,
"git_branch": branch,
}

if arch is not None:
params["filter_architecture"] = arch
return dashboard_api_fetch(endpoint, params)


def dashboard_fetch_boots(origin, giturl, branch, commit):
def dashboard_fetch_boots(origin, giturl, branch, commit, arch):
endpoint = f"tree/{commit}/boots"
params = {
"origin": origin,
"git_url": giturl,
"git_branch": branch,
}

if arch is not None:
params["filter_architecture"] = arch
return dashboard_api_fetch(endpoint, params)


def dashboard_fetch_tests(origin, giturl, branch, commit):
def dashboard_fetch_tests(origin, giturl, branch, commit, arch):
endpoint = f"tree/{commit}/tests"
params = {
"origin": origin,
"git_url": giturl,
"git_branch": branch,
}

if arch is not None:
params["filter_architecture"] = arch
return dashboard_api_fetch(endpoint, params)


Expand Down Expand Up @@ -439,6 +443,7 @@ def common_options(func):
is_flag=True,
help="Select latest results available",
)
@click.option("--arch", help="Filter by arch")
@wraps(func)
def wrapper(*args, **kwargs):
return func(*args, **kwargs)
Expand Down Expand Up @@ -480,20 +485,12 @@ def results(ctx):
@results.command()
@common_options
@click.pass_context
def summary(
ctx,
origin,
git_folder,
giturl,
branch,
commit,
latest,
):
def summary(ctx, origin, git_folder, giturl, branch, commit, latest, arch):
"""Display a summary of results."""
giturl, branch, commit = set_giturl_branch_commit(
origin, giturl, branch, commit, latest, git_folder
)
data = dashboard_fetch_summary(origin, giturl, branch, commit)
data = dashboard_fetch_summary(origin, giturl, branch, commit, arch)
cmd_summary(data)


Expand Down Expand Up @@ -521,6 +518,7 @@ def builds(
branch,
commit,
latest,
arch,
download_logs,
status,
filter,
Expand All @@ -529,7 +527,7 @@ def builds(
giturl, branch, commit = set_giturl_branch_commit(
origin, giturl, branch, commit, latest, git_folder
)
data = dashboard_fetch_builds(origin, giturl, branch, commit)
data = dashboard_fetch_builds(origin, giturl, branch, commit, arch)
cmd_builds(data, commit, download_logs, status)


Expand All @@ -545,6 +543,7 @@ def boots(
branch,
commit,
latest,
arch,
download_logs,
status,
filter,
Expand All @@ -553,7 +552,7 @@ def boots(
giturl, branch, commit = set_giturl_branch_commit(
origin, giturl, branch, commit, latest, git_folder
)
data = dashboard_fetch_boots(origin, giturl, branch, commit)
data = dashboard_fetch_boots(origin, giturl, branch, commit, arch)
cmd_tests(data["boots"], commit, download_logs, status, filter)


Expand All @@ -569,6 +568,7 @@ def tests(
branch,
commit,
latest,
arch,
download_logs,
status,
filter,
Expand All @@ -577,7 +577,7 @@ def tests(
giturl, branch, commit = set_giturl_branch_commit(
origin, giturl, branch, commit, latest, git_folder
)
data = dashboard_fetch_tests(origin, giturl, branch, commit)
data = dashboard_fetch_tests(origin, giturl, branch, commit, arch)
cmd_tests(data["tests"], commit, download_logs, status, filter)


Expand Down