results: refactor of the subcommand code #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padovan
reviewed
Mar 12, 2025
Contributor
padovan
left a comment
padovan
left a comment
There was a problem hiding this comment.
I like this! Left a few comments
| @@ -0,0 +1,98 @@ | |||
| import urllib | |||
Contributor
There was a problem hiding this comment.
I'd move this file to libs/dashboard.py
Contributor
Author
There was a problem hiding this comment.
Good idea. Then we can extend this module with extra functions for new subcommands
| @@ -0,0 +1,107 @@ | |||
| import configparser | |||
Contributor
There was a problem hiding this comment.
maybe this can go into libs/git-repo.py. @aliceinwire what do you think?
Signed-off-by: Camila Alvarez <cam.alvarez.i@gmail.com>
CamilaAlvarez
force-pushed
the
results-refactor
branch
from
a5dd49e to
19ae4b5
Compare
Contributor
Author
|
Thanks for the comments! I have applied them |
padovan
approved these changes
Mar 13, 2025
Member
|
thanks you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.