results: Fix dashboard_fetch_tree_list() invocation #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit d45d0db ("Format error as json when using --json") added a new positional argument called "use_json" to the dashboard_api_fetch() method while fixing something else. As part of the change, most of the callers of the dashboard_api_fetch(), such as the dashboard_fetch_tree_list() helper, were updated to correctly pass the new argument around. However, the cmd_list_trees() was not updated to pass the new argument correctly to the aforementioned helper function, which it uses internally. As such, when using kci-dev with the "results trees" subcommand, this results in a TypeError as follows: TypeError: dashboard_fetch_tree_list() missing 1 required positional argument: 'use_json' Thus, add the missing argument when invoking dashboard_fetch_tree_list() to fix the subcommand invocation error. Signed-off-by: Krzysztof Wilczyński <krzysztof.wilczynski@collabora.com>
padovan
approved these changes
Apr 3, 2025
Member
|
thanks for the fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d45d0db ("Format error as json when using --json") added a new positional argument called use_json to the
dashboard_api_fetch()method while fixing something else.As part of the change, most of the callers of the
dashboard_api_fetch(), such as thedashboard_fetch_tree_list()helper, were updated to correctly pass the new argument around.However, the
cmd_list_trees()was not updated to pass the new argument correctly to the aforementioned helper function, which it uses internally.As such, when using kci-dev with the "results trees" subcommand, this results in a
TypeErroras follows:Thus, add the missing argument when invoking
dashboard_fetch_tree_list()to fix the subcommand invocation error.