fix(results): remove invalid nl parameter from kci_msg_nonl calls #186
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kci_msg_nonl() function doesn't accept any parameters, but was being called with nl=False in print_summary(), causing a TypeError: TypeError: kci_msg_nonl() got an unexpected keyword argument 'nl' This fix removes the invalid parameter and uses the nl parameter correctly on the color message functions (kci_msg_green, kci_msg_red) instead. Fixes: 19ae4b5 ("Add print summary function") Signed-off-by: Sasha Levin <sashal@kernel.org>
padovan
approved these changes
Jun 25, 2025
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kci_msg_nonl() function doesn't accept any parameters, but was being called with nl=False in print_summary(), causing a TypeError:
TypeError: kci_msg_nonl() got an unexpected keyword argument 'nl'
This fix removes the invalid parameter and uses the nl parameter correctly on the color message functions (kci_msg_green, kci_msg_red) instead.
Fixes: 19ae4b5 ("Add print summary function")