Fix kci-dev results hardware list #195
Merged
+96
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardware list command was failing due to two issues: 1. API parameter inconsistency: Used 'startTimestampInSeconds' instead of 'startTimestampInSeconds' (wrong case). Updated to match API spec and use string format as documented. 2. Response structure mismatch: Code expected 'hardware_name' field but API returns 'hardware' field (often null) and 'platform' field. Updated parser to use hardware field as fallback to platform. Fixes the 400 Bad Request error and KeyError when running: kci-dev results hardware list --origin maestro Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Adds comprehensive tests to verify the hardware list functionality: 1. test_kcidev_results_hardware_list: Tests standard text output format - Verifies command returns success (exit code 0) - Checks output contains expected '- name:' and 'compatibles:' patterns - Ensures matching number of hardware entries 2. test_kcidev_results_hardware_list_json: Tests JSON output format - Verifies JSON output is valid and parseable - Checks each entry has required 'name' and 'compatibles' fields - Validates field data types are strings as expected These tests ensure the recent hardware list API fixes work correctly and prevent future regressions. Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command was throwing us a 400 after some Dashboard API changes. Fix that and also add a test to make sure we don't regress.