Relocate /dhcp-client to /interfaces/interface/ipv4/dhcp #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troglobit
force-pushed
the
migrate-dhcp-client
branch
from
4a9cecc to
918353d
Compare
troglobit
changed the title
mattiaswal
approved these changes
Nov 3, 2025
Contributor
mattiaswal
left a comment
mattiaswal
left a comment
There was a problem hiding this comment.
Great work, just minor comment.
Silence confd[3582]: libyang[0]: Invalid argument ctx_node (lyd_find_xpath()) warning in syslog. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Please note, this change drops not only the global enabled flag, but also the per-interface enabled flag, converting it to a presence container. The name of the container is also shortened from dhcp-client -> dhcp. A pattern that expected to be reused also for the DHCPv6 client. Fixes #1109 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Neither the IPv6 autonconf container, nor the recently moved DHCP client container have an 'enabled' flag. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The callback refactoring forgot to call ietf_interfaces_cand_init(), breaking inference of interface types and DHCP client options. Also fixes UPDATE event handling for ietf-keystore and infix-meta. Fixes #1244 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
troglobit
force-pushed
the
migrate-dhcp-client
branch
from
918353d to
80e8ccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please note, this change drops not only the global enabled flag, but also the per-interface enabled flag, converting it to a presence container. The name of the container is also shortened from dhcp-client -> dhcp. A pattern that expected to be reused also for the DHCPv6 client.
For consistency, the
enabledsetting for IPv4 autoconf (ZeroConf) has been dropped in favor of a presence container.Fixes #1109
Checklist
Tick relevant boxes, this PR is-a or has-a: