Fixes to misc. boot warnings #1230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silence confd[3582]: libyang[0]: Invalid argument ctx_node (lyd_find_xpath()) warning in syslog. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Please note, this change drops not only the global enabled flag, but also the per-interface enabled flag, converting it to a presence container. The name of the container is also shortened from dhcp-client -> dhcp. A pattern that expected to be reused also for the DHCPv6 client. Fixes #1109 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Neither the IPv6 autonconf container, nor the recently moved DHCP client container have an 'enabled' flag. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
In 45efa94 we introduced new mount options for the: 'aux', 'cfg', and 'var' partitions. To save boot time, we also disabled the periodic fsck check, which does not affect journal replay or other Ext4 safety or integrity checks. The latter involved calling tune2fs at runtime, but this caused the following to appear for the 'aux' partition, which is an ext2 for systems that need to change U-Boot settings, e.g., to set MAC address on systems without a VPD. EXT4-fs: Mount option(s) incompatible with ext2 To make matters worse, the new mount option(s), e.g., 'commit=30', gave us another set of warnings from the kernel. This was due to the fstype being 'auto', so the kernel objected to options not being applicable to every filesystem it tried before ending up with extfs: squashfs: Unknown parameter 'commit' vfat: Unknown parameter 'commit' exfat: Unknown parameter 'commit' fuseblk: Unknown parameter 'commit' btrfs: Unknown parameter 'errors' This commit explicitly sets aux to ext2, and the others to ext4, and it now checks before calling tune2fs that the partition/disk image is ext4. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Check if partition/LABEL is available before trying to run tune2fs and
mount commands on it. This change masks the kernel output:
LABEL=var: Can't lookup blockdev
commne when running `make run` on x86_64 builds.
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Collapse, simplify, and break up ietf_keystore_change() into multiple functions. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This fixes the annoying libyang warning after commit da29771. confd[3375]: libyang[0]: Invalid argument ctx_node (lyd_find_xpath()). This happens when the diff is used in the wrong event when it is NULL. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Contributor
Author
|
Sorry, this branch had the wrong origin. I'll await the build + test, then I'll spin off this as a new branch off origin/main. |
Contributor
Author
|
Closing in favor of #1232 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a mixed bag of fixes and follow-ups to recent commits after the last release. I.e., changes within the release cycle.
use new
print_*()framework that shows Finit style console messagesPlease see commit message for the full details
/var)Checklist
Tick relevant boxes, this PR is-a or has-a: