Skip to content

Conversation

@mattiaswal
Copy link
Contributor

Description

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@mattiaswal mattiaswal marked this pull request as ready for review November 4, 2025 22:49
@mattiaswal mattiaswal changed the title Bananapi emmc Bananapi eMMC support Nov 4, 2025
Comment on lines +8 to +9
This is copied from linux where it is an overlay, unfortunatly it is not
possible to use dtbo in sysboot unless present in syslinux.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it makes sense or not, but the standard scripts do check for a board-specific syslinux.conf before falling back to the generic one:

for conf in "${board}-syslinux.conf syslinux.conf"; do
if test -e blkmap ${blkmapnum} /boot/syslinux/${conf}; then
sysboot blkmap ${blkmapnum} any ${scriptaddr} /boot/syslinux/${conf}
fi
done

Copy link
Contributor Author

@mattiaswal mattiaswal Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still the same board SD/eMMC. Both are bananapi-r3. But I do not see any need for it now anyway.

Not sure if it makes sense or not, but the standard scripts do check for a board-specific syslinux.conf before falling back to the generic one:

for conf in "${board}-syslinux.conf syslinux.conf"; do
if test -e blkmap ${blkmapnum} /boot/syslinux/${conf}; then
sysboot blkmap ${blkmapnum} any ${scriptaddr} /boot/syslinux/${conf}
fi
done

@mattiaswal mattiaswal requested review from troglobit and wkz November 6, 2025 20:27
@mattiaswal mattiaswal force-pushed the bananapi-emmc branch 2 times, most recently from 50fcfe6 to 3765d54 Compare November 6, 2025 20:39
@mattiaswal
Copy link
Contributor Author

Please test the flow described in the Readme.md @troglobit.

@mattiaswal mattiaswal force-pushed the bananapi-emmc branch 2 times, most recently from 104ab4f to fd2c9d1 Compare November 7, 2025 15:00
@troglobit
Copy link
Contributor

Please test the flow described in the Readme.md @troglobit.

Made it work this morning. But the experience was horrifying! 😨 We just have to improve the UX on this one .. or at least fix up the genimage.cfg.in and mkimage.sh tooling to create ready-made emmc image, because just that took me an hour of getting stuck before I got it working.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
[skip ci]

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Copy link
Contributor

@troglobit troglobit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! I tried updating the README.md a bit and also fixed up mkimage.sh to support eMMC for use in the workflow.

We should test the workflow and instructions before merging this, I've just verified it all works locally.

@troglobit troglobit merged commit 00f2061 into main Nov 14, 2025
8 of 9 checks passed
@troglobit troglobit deleted the bananapi-emmc branch November 14, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants