feat: move to the new scripting engine #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
feat/refactor-to-new-script-lib
branch
2 times, most recently
from
6e4eca0 to
d83d54e
Compare
tchiotludo
requested changes
Aug 14, 2023
| @Schema(title = "Deprecated, use the `docker` property instead", deprecated = true) | ||
| @PluginProperty | ||
| @Deprecated | ||
| public DockerOptions getDockerOptions() { |
Member
There was a problem hiding this comment.
does the getter is needed (only the setter no?)
Member
Author
There was a problem hiding this comment.
without the getter the property is not added to the JSONSchema so old flow will no longer validate.
Member
There was a problem hiding this comment.
it's a good way to force the migration no?
loicmathieu
force-pushed
the
feat/refactor-to-new-script-lib
branch
2 times, most recently
from
a98d55a to
f8cd319
Compare
loicmathieu
force-pushed
the
feat/refactor-to-new-script-lib
branch
from
f8cd319 to
55a813a
Compare
tchiotludo
force-pushed
the
feat/refactor-to-new-script-lib
branch
2 times, most recently
from
9a8038f to
78dcafb
Compare
tchiotludo
force-pushed
the
feat/refactor-to-new-script-lib
branch
from
2a63ff7 to
2941b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.