fix: update the example as kestra-demo is now based on DuckDB #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
force-pushed
the
fix/example
branch
from
1ddfdd5 to
5062846
Compare
anna-geller
approved these changes
Aug 25, 2023
Member
There was a problem hiding this comment.
LGTM
This repo https://github.com/kestra-io/dbt-demo works with any adapter, not only with DuckDB (the README from the forked repo may be a bit misleading)
still worth taking DuckDB as a default example everywhere as it allows testing each command locally with no setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@anna-geller I notice you change the DBT Kestra demo to use DuckDB so the example must on the DbtCLI task must be udpated