-
Notifications
You must be signed in to change notification settings - Fork 0
ci: Fix builds #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(M1/M2/M3) Macs\n- Update CI workflow to only build for aarch64-apple-darwin\n- Update README to document platform support\n- Other platforms will be added behind a feature flag in future releases
…ect Apple Silicon artifacts\n- Remove other platforms from test matrix
…h dry-run mode\n- Skip npm auth and real publishing on PRs\n- Keep real publishing for tags only
…nd step names\n- Make workflow more visually appealing
…uild job\n- Fix formatting and remove extra newlines
…arget in build command\n- Update target names to match Node.js platform names\n- Add debug output to see binary names
| (reservation.car.pickupLocation == reservation.flight.arrivalAirport || | ||
| reservation.car.pickupLocation == reservation.hotel.address.city) && | ||
| size(reservation.travelers) <= reservation.hotel.maxOccupancy && | ||
| size(reservation.travelers) <= reservation.car.capacity |
Owner
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cel-rust appears to not support the array.min() function that would simplify this
size(res.travelers) <= [a, b].min()
| double(reservation.hotel.nightlyRate) * int(reservation.hotel.nights) + | ||
| double(reservation.car.dailyRate) * int(reservation.car.days); | ||
| let seasonalPrice = basePrice * (timestamp(reservation.hotel.checkIn).getMonth() in [11, 0, 1] ? 1.25 : 1.0); | ||
| seasonalPrice * (1.0 - {'BRONZE': 0.05, 'SILVER': 0.10, 'GOLD': 0.15, 'PLATINUM': 0.20}[reservation.customer.loyaltyTier]) |
Owner
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think CEL supports let
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.