Skip to content

Fixing HTTP path parsing #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fixing HTTP path parsing #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions modules/processing/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,16 @@ def _add_http(self, conn, tcpdata):
if entry["port"] != 80 and ":" not in netloc:
netloc += f":{entry['port']}"

entry["data"] = convert_to_printable(tcpdata)
entry["uri"] = convert_to_printable(urlunparse(("http", netloc, http.uri, None, None, None)))
# Sometimes the host is found inside the path in the HTTP headers. When that happens, parse the host outside of the path.
path = http.uri
if netloc and netloc in http.uri:
path = http.uri.split(netloc)[1]
elif entry["host"] and entry["host"] in http.uri:
path = http.uri.split(entry["host"])[1]

entry["uri"] = convert_to_printable(urlunparse(("http", netloc, path, None, None, None)))
entry["body"] = convert_to_printable(http.body)
entry["path"] = convert_to_printable(http.uri)
entry["path"] = convert_to_printable(path)
entry["user-agent"] = convert_to_printable(http.headers["user-agent"]) if "user-agent" in http.headers else ""
entry["version"] = convert_to_printable(http.version)
entry["method"] = convert_to_printable(http.method)
Expand Down