-
Notifications
You must be signed in to change notification settings - Fork 498
Only show interactive options and infos when enabled and used (AI imp… #2710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ClaudioWayne, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user interface and backend logic for task submission and status viewing. It introduces conditional rendering of interactive options on the submission page, ensuring that users only see and interact with features that are actively configured. Additionally, it refines the display of remote session details on the task status page, making the information more relevant and reducing visual clutter. The changes aim to streamline the user experience by presenting options and information contextually. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces several UI/UX improvements related to interactive analysis sessions. It conditionally displays interactive options on the submission page based on configuration, adds logic to enable/disable the 'manual detonation' checkbox based on the 'interactive desktop' selection, and ensures remote session information is only shown on the task status page when an interactive session is active. The changes are well-implemented and align with the PR's goals. I've added one minor comment regarding HTML formatting for better code consistency.
| <div class="progress progress-striped active" style="margin-top: 10px;"> | ||
| <div class="progress-bar progress-bar-striped progress-bar-animated" style="width:100%"></div> | ||
| </div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation for the inner div of the progress bar is excessive, which harms code readability. It's a good practice to maintain consistent indentation.
<div class="progress progress-striped active" style="margin-top: 10px;">
<div class="progress-bar progress-bar-striped progress-bar-animated" style="width:100%"></div>
</div>
|
AI doesn't complain about AI code that's great. Thank you |
…rovements)