Skip to content

Conversation

@tmadlener
Copy link
Member

BEGINRELEASENOTES

  • Make the python bindings install prefix conform to python conventions by default and allow overriding with the EDM4HEP_PYTHON_INSTALLDIR cmake variable
    • Default prefix is now <prefix>/lib[64]/pythonX.Y/site-packages (where lib or lib64 is defined from the platform defaults and X.Y is the python major and minor version).

ENDRELEASENOTES

Fixes #220

See AIDASoft/podio#599 for some discussion on how we arrived at this solution.

@tmadlener
Copy link
Member Author

The corresponding changes for spack are ready here. I will open a PR to upstream spack as soon as this is merged.

Copy link
Member

@jmcarcell jmcarcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The PR in spack can go ahead, if it's merged then I don't have to cherry-pick from your fork.

@tmadlener tmadlener merged commit cd24d43 into key4hep:main Jun 12, 2024
@tmadlener tmadlener deleted the python-prefix branch June 12, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python Install Location

2 participants