Only set the spin if it's available in EDM4hep #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 14, 2025
tmadlener
commented
Aug 14, 2025
andresailer
reviewed
Aug 19, 2025
| edm_particle.setMass(p.m()); | ||
|
|
||
| #ifdef EDM4HEP_MCPARTICLE_HAS_HELICITY | ||
| // TODO: Figure out what actually needs to go here |
There was a problem hiding this comment.
Whatever is decided here, we should use the same in DD4hep's HepMC reader.
tmadlener
changed the title
|
I will merge this later today unless there anyone is seriously unhappy about it. I would like to unblock key4hep/EDM4hep#404 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
helicityinstead of thespinif it becomes available in EDM4hepENDRELEASENOTES
For now this is mainly here to have a PR to refer to and to at some point merge to keep the nightlies building.