Skip to content

Conversation

@ansasaki
Copy link
Contributor

Introduce a new AgentIdentity structure that contains the Agent identity information, removing the corresponding data from the RegistrarClient structure.

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 89.45148% with 25 lines in your changes missing coverage. Please review.

Project coverage is 69.40%. Comparing base (5050ee9) to head (4da24bb).

Files with missing lines Patch % Lines
keylime/src/registrar_client.rs 78.57% 24 Missing ⚠️
keylime/src/agent_identity.rs 99.09% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 69.40% <89.45%> (-0.03%) ⬇️
upstream-unit-tests 69.40% <89.45%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime/src/agent_registration.rs 93.05% <100.00%> (+0.40%) ⬆️
keylime/src/keylime_error.rs 62.96% <ø> (ø)
keylime/src/agent_identity.rs 99.09% <99.09%> (ø)
keylime/src/registrar_client.rs 86.66% <78.57%> (-7.36%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for comments removal. Rest of changes LGTM

ansasaki added 2 commits June 2, 2025 11:49
Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
The AgentIdentity structure contains all the data used to identify the
agent (i.e. keys, certificates, etc)

This removes the information related to the Agent from the
RegistrarClient.

Signed-off-by: Anderson Toshiyuki Sasaki <ansasaki@redhat.com>
@ansasaki ansasaki merged commit 1a5ab2b into keylime:master Jun 2, 2025
5 of 6 checks passed
@ansasaki ansasaki deleted the agent_identity branch June 2, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants