Skip to content

Conversation

@sarroutbi
Copy link
Contributor

@sarroutbi sarroutbi commented Jul 23, 2025

The primary reason for this change is to improve code clarity and consistency. Using the full word exponential_backoff instead of the abbreviation expbackoff makes the configuration options easier to understand for new developers and aligns them with the naming conventions used elsewhere in the Keylime codebase. This change has no impact on functionality. To address this, renaming of three configuration variables is performed across the codebase to be more descriptive and consistent:

  • expbackoff_initial_delay is now exponential_backoff_initial_delay
  • expbackoff_max_retries is now exponential_backoff_max_retries
  • expbackoff_max_delay is now exponential_backoff_max_delay

This renaming has been applied consistently in all the places where these parameters are defined or used:

  • Configuration Structs (keylime/src/config/base.rs & push_model.rs): The field names in the main AgentConfig struct and the PushModelConfig view have been updated to reflect the new names.

  • Agent Logic (keylime-push-model-agent/src/main.rs & registration.rs): All code that accesses these configuration values, either through direct struct access or via getter methods, has been updated to use the new, more descriptive names.

Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202507231121-align-to-current-configuration-values branch from 806481a to ebecba9 Compare July 23, 2025 09:24
@sarroutbi sarroutbi requested a review from ansasaki July 23, 2025 09:38
@ansasaki ansasaki merged commit 100167a into keylime:master Jul 23, 2025
11 of 12 checks passed
@sarroutbi sarroutbi requested a review from sergio-correia July 23, 2025 14:21
@sarroutbi sarroutbi deleted the 202507231121-align-to-current-configuration-values branch July 23, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants