Skip to content

Conversation

@THS-on
Copy link
Member

@THS-on THS-on commented Mar 4, 2025

The other algorithms, while supported by the TPM, are not supported on the Keylime verifier side.

@codecov
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.24%. Comparing base (329329d) to head (d41a1c5).

Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 62.24% <ø> (-0.05%) ⬇️
upstream-unit-tests 62.24% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Copy link
Contributor

@sarroutbi sarroutbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your change. LGTM

@ansasaki
Copy link
Contributor

LGTM! @THS-on could you please do a similar change updating the configuration file templates? I mean, modifying the line similar to the following for all template versions:

https://github.com/keylime/keylime/blob/bac42c41058a84efb8e52e43c28f82a5e2e2fbaa/templates/2.4/agent.j2#L173

The other algorithms, while supported by the TPM, are not supported on the
Keylime verifier side.

Signed-off-by: Thore Sommer <mail@thson.de>
@ansasaki ansasaki force-pushed the remove-unsupported-algs branch from d41a1c5 to 47a80bf Compare March 11, 2025 17:30
@ansasaki ansasaki merged commit a18dbe2 into keylime:master Mar 12, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants