Skip to content

Conversation

@sarroutbi
Copy link
Contributor

No description provided.

@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch 19 times, most recently from 68dc3fb to 41c9cd2 Compare April 14, 2025 11:07
@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (5adedcf) to head (ba97480).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keylime-push-model-agent/src/main.rs 77.27% 5 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
e2e-testsuite 63.70% <77.27%> (+0.01%) ⬆️
upstream-unit-tests 63.70% <77.27%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
keylime-push-model-agent/src/main.rs 88.23% <77.27%> (-1.30%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch 7 times, most recently from 6813ac8 to 212a176 Compare April 14, 2025 18:30
@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch 3 times, most recently from 297a14a to 954b880 Compare April 22, 2025 16:01
@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch 3 times, most recently from 6f263d8 to 56a5538 Compare April 23, 2025 09:28
@sarroutbi sarroutbi marked this pull request as ready for review April 23, 2025 10:36
@sarroutbi sarroutbi changed the title [DONOTMERGE]: Add mockoon test scenario Add mockoon test scenario Apr 23, 2025
@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch from 56a5538 to 47f1451 Compare April 23, 2025 10:37
@sarroutbi sarroutbi requested a review from ansasaki April 23, 2025 11:47
@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch from 47f1451 to adcde11 Compare April 24, 2025 09:11
@sarroutbi
Copy link
Contributor Author

sarroutbi commented Apr 24, 2025

/packit retest-failed

3 similar comments
@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch from adcde11 to ba1390e Compare April 25, 2025 07:07
@sarroutbi
Copy link
Contributor Author

/packit retest-failed

2 similar comments
@sarroutbi
Copy link
Contributor Author

/packit retest-failed

@sarroutbi
Copy link
Contributor Author

/packit retest-failed

Copy link
Contributor

@ansasaki ansasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good. I added a comment about the location of the mock OpenAPI specification

@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch from ba1390e to 82b5ae8 Compare May 5, 2025 10:54
Signed-off-by: Sergio Arroutbi <sarroutb@redhat.com>
@sarroutbi sarroutbi force-pushed the 202504141107-add-mockoon-scenario branch from 82b5ae8 to ba97480 Compare May 5, 2025 14:13
@ansasaki ansasaki merged commit 1621e73 into keylime:master May 5, 2025
12 checks passed
@sarroutbi sarroutbi deleted the 202504141107-add-mockoon-scenario branch May 5, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants