Update routes.py #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if name: | ||
| cursor.execute( | ||
| "SELECT * FROM books WHERE name LIKE %s", name | ||
| "SELECT * FROM books WHERE name LIKE '%" + name + "%'" |
Check failure
Code scanning / CodeQL
SQL query built from user-controlled sources High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 10 months ago
To fix the SQL injection vulnerability, we should use parameterized queries instead of directly concatenating user input into the SQL query. Parameterized queries ensure that user input is properly escaped and treated as data rather than executable code.
In this specific case, we need to modify the SQL query on line 16 to use a parameterized query. We will use the LIKE operator with a parameter placeholder and pass the user input as a parameter to the execute method.
Suggested changeset
1
server/routes.py
| @@ -15,3 +15,3 @@ | ||
| cursor.execute( | ||
| "SELECT * FROM books WHERE name LIKE '%" + name + "%'" | ||
| "SELECT * FROM books WHERE name LIKE %s", ('%' + name + '%',) | ||
| ) |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.