Add a 'Decision' heading.#179
Merged
virgil-serbanuta merged 3 commits intoruntimeverification:masterfrom Aug 10, 2018
Merged
Conversation
virgil-serbanuta
force-pushed
the
read-patterns
branch
from
25aebcd to
cc8ba22
Compare
bmmoore
approved these changes
Aug 9, 2018
Contributor
bmmoore
left a comment
bmmoore
left a comment
There was a problem hiding this comment.
This formatting makes the conclusion much easier to notice!
jberthold
pushed a commit
that referenced
this pull request
Apr 10, 2024
This PR implements #177 which adds internalised maps to the `Term` type, by deconstructing any `SymbolApplication` with a known map constructor into a `KMap attrs keyVals rest`, where: * `attrs` carries the map information, necessary to reconstruct the original map * `keyVals` is a list of key value pairs, obtained from deconstructing a chain of `SymbolApplication attrs.concat [..., SymbolApplication attrs.concat [SymbolApplication attrs.element [k, v] SymbolApplication attrs.unit []]...]` * `rest` is any term which doesn't fit the above pattern, e.g. a variable or a function symbol with the return type of the map This representation makes it easy to do limited forms of unification when e.g. the keys in both maps are fully defined and we are matching `K1 -> V1 ... Kn -> Vn REST` with a fully concrete map. This PR also adds handling of overload equations (ignored for now), introduced in kevm in runtimeverification/evm-semantics#1726
jberthold
pushed a commit
that referenced
this pull request
Apr 10, 2024
This PR implements #177 which adds internalised maps to the `Term` type, by deconstructing any `SymbolApplication` with a known map constructor into a `KMap attrs keyVals rest`, where: * `attrs` carries the map information, necessary to reconstruct the original map * `keyVals` is a list of key value pairs, obtained from deconstructing a chain of `SymbolApplication attrs.concat [..., SymbolApplication attrs.concat [SymbolApplication attrs.element [k, v] SymbolApplication attrs.unit []]...]` * `rest` is any term which doesn't fit the above pattern, e.g. a variable or a function symbol with the return type of the map This representation makes it easy to do limited forms of unification when e.g. the keys in both maps are fully defined and we are matching `K1 -> V1 ... Kn -> Vn REST` with a fully concrete map. This PR also adds handling of overload equations (ignored for now), introduced in kevm in runtimeverification/evm-semantics#1726
jberthold
pushed a commit
that referenced
this pull request
Apr 10, 2024
This PR implements #177 which adds internalised maps to the `Term` type, by deconstructing any `SymbolApplication` with a known map constructor into a `KMap attrs keyVals rest`, where: * `attrs` carries the map information, necessary to reconstruct the original map * `keyVals` is a list of key value pairs, obtained from deconstructing a chain of `SymbolApplication attrs.concat [..., SymbolApplication attrs.concat [SymbolApplication attrs.element [k, v] SymbolApplication attrs.unit []]...]` * `rest` is any term which doesn't fit the above pattern, e.g. a variable or a function symbol with the return type of the map This representation makes it easy to do limited forms of unification when e.g. the keys in both maps are fully defined and we are matching `K1 -> V1 ... Kn -> Vn REST` with a fully concrete map. This PR also adds handling of overload equations (ignored for now), introduced in kevm in runtimeverification/evm-semantics#1726
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer checklist
stack test --coveragestack haddockstylish-haskell