Skip to content

Conversation

@dachafra
Copy link
Member

@pmaria I don't know why output-dataset was included in #244, but please, use this PR to review the whole section.

@dachafra dachafra requested a review from pmaria October 10, 2025 11:03
Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output dataset section is missing descriptions on multivalued term maps and on language maps and datatype maps.

@dachafra dachafra requested a review from pmaria October 14, 2025 11:07
@dachafra
Copy link
Member Author

Descriptions of datatype/language maps and multivalues are provided

@dachafra
Copy link
Member Author

@pmaria can we merge this PR?

Copy link
Collaborator

@pmaria pmaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes on parts of the text that were merged earlier and I cannot comment on in this PR:

line 93 and 94. The mentions of [=URI=] can be left out, since a URI is an IRI.

I notice in the Adding Triples to the Output Dataset section two points that are new compared to R2RML:

  1. RDF graphs MUST NOT contain duplicate triples. Adding multiple identical triples to the same graph has the same effect as adding it once.

I cannot recall discussing this in the group. But I do not agree with this point. Deduping does not matter in many cases, and should depend on the implementation and the use case.

  1. The scope of blank nodes is limited to the output dataset being generated.

This is true, but seems somewhat misplaced in this section. I think it would make more sense in the Generated RDF Term of a Term Map section.

dachafra and others added 17 commits November 24, 2025 07:39
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
dachafra and others added 6 commits November 24, 2025 07:43
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
@dachafra
Copy link
Member Author

Both points you mention @pmaria are included in R2RML, see last sentence of R2RML spec 11.1, but, indeed, the scope of BN is not in this sect. I'll move it to the corresponding one with a reference.

@dachafra dachafra requested a review from pmaria November 25, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants