-
Notifications
You must be signed in to change notification settings - Fork 11
Output dataset section #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Include last updates
pmaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The output dataset section is missing descriptions on multivalued term maps and on language maps and datatype maps.
|
Descriptions of datatype/language maps and multivalues are provided |
|
@pmaria can we merge this PR? |
pmaria
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes on parts of the text that were merged earlier and I cannot comment on in this PR:
line 93 and 94. The mentions of [=URI=] can be left out, since a URI is an IRI.
I notice in the Adding Triples to the Output Dataset section two points that are new compared to R2RML:
- RDF graphs MUST NOT contain duplicate triples. Adding multiple identical triples to the same graph has the same effect as adding it once.
I cannot recall discussing this in the group. But I do not agree with this point. Deduping does not matter in many cases, and should depend on the implementation and the use case.
- The scope of blank nodes is limited to the output dataset being generated.
This is true, but seems somewhat misplaced in this section. I think it would make more sense in the Generated RDF Term of a Term Map section.
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
Co-authored-by: Pano Maria <pano.maria@gmail.com>
|
Both points you mention @pmaria are included in R2RML, see last sentence of R2RML spec 11.1, but, indeed, the scope of BN is not in this sect. I'll move it to the corresponding one with a reference. |
@pmaria I don't know why output-dataset was included in #244, but please, use this PR to review the whole section.