-
Notifications
You must be signed in to change notification settings - Fork 7
AI SDK #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
test-ai-sdk.ts
Outdated
| @@ -0,0 +1,25 @@ | |||
| import { getRegistry, getAvailableProviders } from './src/llms/ai-sdk/unified-registry.js'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test file that should be deleted?
|
|
||
| export default defineConfig({ | ||
| plugins: [svelte(), svelteTesting()], | ||
| plugins: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paoloricciuti Do you happen to know why this change is required when migrating from Vitest 3 to 4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw some issue about it I think...it should probably be fixed in vitest
| import { svelte } from "@sveltejs/vite-plugin-svelte"; | ||
| import { svelteTesting } from "@testing-library/svelte/vite"; | ||
|
|
||
| export default defineConfig({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in #51 (comment) I don't really see the value of updating to Vitest 4, but I do see a potential issue (tests not working exactly the same as in v3).
|
@copilot please clean up and shorten readme, when keeping legacy features please tag them as (legacy). Then please create a short bulleted markdown doc with suggestions for improving and streamlining UX (suggestions.md) |
|
@maxffarrell I've opened a new pull request, #54, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: maxffarrell <72176209+maxffarrell@users.noreply.github.com>
|
@copilot please scope and evaluate cost benefit of migrating to bun primarily for using bun.secret native credential storage versus current env file for api keys. At the end Give a definitive answer as to whether this is a good idea and if not suggest best alternative |
|
@maxffarrell I've opened a new pull request, #55, to work on those changes. Once the pull request is ready, I'll request review from you. |
Streamline README and document UX improvement opportunities
@maxffarrell Hope you don't mind that I start a PR off your branch, I saw it when I was going to work on the same thing, so we can combine the effort. :-)