Skip to content

Conversation

@khromov
Copy link
Owner

@khromov khromov commented Oct 28, 2025

@maxffarrell Hope you don't mind that I start a PR off your branch, I saw it when I was going to work on the same thing, so we can combine the effort. :-)

test-ai-sdk.ts Outdated
@@ -0,0 +1,25 @@
import { getRegistry, getAvailableProviders } from './src/llms/ai-sdk/unified-registry.js';
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test file that should be deleted?


export default defineConfig({
plugins: [svelte(), svelteTesting()],
plugins: [
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paoloricciuti Do you happen to know why this change is required when migrating from Vitest 3 to 4?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw some issue about it I think...it should probably be fixed in vitest

import { svelte } from "@sveltejs/vite-plugin-svelte";
import { svelteTesting } from "@testing-library/svelte/vite";

export default defineConfig({
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in #51 (comment) I don't really see the value of updating to Vitest 4, but I do see a potential issue (tests not working exactly the same as in v3).

@maxffarrell
Copy link
Collaborator

@copilot please clean up and shorten readme, when keeping legacy features please tag them as (legacy). Then please create a short bulleted markdown doc with suggestions for improving and streamlining UX (suggestions.md)

Copy link
Contributor

Copilot AI commented Oct 29, 2025

@maxffarrell I've opened a new pull request, #54, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: maxffarrell <72176209+maxffarrell@users.noreply.github.com>
@maxffarrell
Copy link
Collaborator

@copilot please scope and evaluate cost benefit of migrating to bun primarily for using bun.secret native credential storage versus current env file for api keys. At the end Give a definitive answer as to whether this is a good idea and if not suggest best alternative

Copy link
Contributor

Copilot AI commented Oct 29, 2025

@maxffarrell I've opened a new pull request, #55, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants