-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] - Added dialog for currency change #339
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added logic to hide privacy rows when the user is a creator * fixed test issue * PR feedback with Rashad * we love it * 1 fix
* making the toolbar the accent color so you know you're not hitting production
Added adapter for Email custom scalar. In the `TestApolloActivity`, logged in users can now update their email addresses.
Made the search EditText confirm to minimum touch target size. Made the search EditText take up the width between back button and clear icon.
* added account screen with all necessary fields also added the strings for the spinner (#326) * refactored method in account activity * removed shipping addresses as per the card * [Enhancement] - Completed Change Email screen layout (#329) * completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback * [Enhancement] - Change Password screen (#330) * added change password screen, toolbar and added style for textinputlayout * refactored styles * [Enhancement] - User can see Edit Profile Screen (#338) * added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error * added viewmodel to change email
* added account screen with all necessary fields also added the strings for the spinner (#326) * refactored method in account activity * removed shipping addresses as per the card * [Enhancement] - Completed Change Email screen layout (#329) * completed screen for change email * added proper dimens from dimens.xml * fixed pr feedback * [Enhancement] - Change Password screen (#330) * added change password screen, toolbar and added style for textinputlayout * refactored styles * [Enhancement] - User can see Edit Profile Screen (#338) * added cells for edit profile and change password * made rows for account in settings and added account activity layout with rows * added toolbar layout, account layout, AccountActivity, Updated SettingsNewViewModel * added edit text and line restrictions * re-added tests that were deleted accidentally * fixed lines and spacing issues * fixed imports * fixed more imports * moved the tests into the right package * setup edit profile cell and added the activity * added toolbar and imageview to edit profile * still fixing layout * updated strings, completed edit profile ui * removed duplicate activity in manifest and sample layout * fixed circle issues * added icon for different screen mods * fixed error * fixed more errors * fixed the last error * added viewmodel to change email * setting up call to change email * still trying to retrieve user email * completed change email screen with logic * fixed circle errors * added contentDescription * added test and removed certain fields * fixed broken test * fixed test * added email mutation test * removed copy pasta * fixed merge conflicts and pr feedback * added new line to snackbar ext * removed url * changed success to void * fixed url again
* Updated strings. Deriving Graphql endpoint from web endpoint so we don't have to manually change it for staging. Created Activity extensions for showing Snackbars. Created reusable Snackbar extensions for success and error messages. The Snackbar extensions return themselves so you can chain them (if you wanted to inflate a success/error snackbar manually). Change password: Showing warning when new password is less than 6 characters. Showing warning when confirm password is not equal to new confirm. Disabling save button until all validations pass. Added 2 new LoginReasons: CHANGE_PASSWORD and RESET_PASSWORD because we want to prefill the email if it's supplied from the intent but need to check if we're showing the reset dialog or change password snackbar. When password is successfully changed, taking user to LoginActivity. LoginActivity shows success snackbar letting the user know their changes were saved. Made LoginActivity's root a CoordinatorLayout so the Snackbar is shown over the keyboard. * clean up * PR feedback from Rashad.
Let's close this and reopen one against master 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See 👀