-
Notifications
You must be signed in to change notification settings - Fork 0
feat: move analytics to script tag #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request modifies the script loading mechanism in the Changes
Sequence DiagramsequenceDiagram
participant Page as Home Page
participant Script as External Script
participant Renderer as Page Renderer
Note over Page: Uses Next.js Script component
Script->>Page: Async Load
Renderer->>Page: Render Simultaneously
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/pages/index.tsx (1)
82-87: Check loading strategy to optimize performance
While theasyncattribute is suitable for non-blocking loads, consider using a dedicated strategy such asafterInteractive(the default) orlazyOnloadto allow the page to render smoothly before loading analytics scripts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/pages/index.tsx(2 hunks)
🔇 Additional comments (1)
src/pages/index.tsx (1)
3-3: Use Next.js Script for better script loading control
Great job using Next.js's Script component! This approach provides more nuanced script loading control, including support for different loading strategies.
This is an automated pull request for branch develop
Summary by CodeRabbit