refactor: short names for KeyboardGestureArea component props
#141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use shorter name for
KeyboardGestureAreaprops.allowToShowKeyboardFromHiddenStateBySwipeUp->showOnSwipeUpallowToDragKeyboardFromShownStateBySwipes->enableSwipeToDismiss💡 Motivation and Context
Short names are better. Honestly I also didn't like such big names, but at the time of the implementation I decided not to think about correct names 😅
By gathering a feedback I've decided to rename it (I've decided not to mark old props as deprecated because it would bring more confusions). I highly doubt there are any people who just started to use this new feature and already shipped it to theirs applications, so I'm going to do a small
1.5.1release after merging this PR.📢 Changelog
JS
Docs
Android
🤔 How Has This Been Tested?
Tested on emulator.
📝 Checklist