Skip to content

Conversation

@kirillzyusko
Copy link
Owner

@kirillzyusko kirillzyusko commented Apr 10, 2023

📜 Description

Use shorter name for KeyboardGestureArea props.

  • allowToShowKeyboardFromHiddenStateBySwipeUp -> showOnSwipeUp
  • allowToDragKeyboardFromShownStateBySwipes -> enableSwipeToDismiss

💡 Motivation and Context

Short names are better. Honestly I also didn't like such big names, but at the time of the implementation I decided not to think about correct names 😅

By gathering a feedback I've decided to rename it (I've decided not to mark old props as deprecated because it would bring more confusions). I highly doubt there are any people who just started to use this new feature and already shipped it to theirs applications, so I'm going to do a small 1.5.1 release after merging this PR.

📢 Changelog

JS

  • renamed props;

Docs

  • renamed props;

Android

  • renamed props and corresponding setters;

🤔 How Has This Been Tested?

Tested on emulator.

📝 Checklist

  • CI successfully passed

@kirillzyusko kirillzyusko added 🤖 android Android specific refactor You changed the code but it didn't affect functionality labels Apr 10, 2023
@kirillzyusko kirillzyusko self-assigned this Apr 10, 2023
@kirillzyusko kirillzyusko marked this pull request as ready for review April 10, 2023 18:44
@kirillzyusko kirillzyusko changed the title refactor: short names for KeyboardGestureArea component refactor: short names for KeyboardGestureArea component props Apr 10, 2023
@kirillzyusko kirillzyusko merged commit de64105 into main Apr 10, 2023
@kirillzyusko kirillzyusko deleted the refactor/keyboard-gesture-area-short-names branch April 10, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 android Android specific refactor You changed the code but it didn't affect functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants